Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple small issues with the speedrun practice timer #4

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Fix multiple small issues with the speedrun practice timer #4

merged 1 commit into from
Feb 18, 2024

Conversation

bobofromkirby64
Copy link
Contributor

Pause the timer while on the ending island, reset the timer after exitting a cassette, and update the timer based on player state and not based on game transition step

@bobofromkirby64
Fix multiple small issues with the speedrun practice timer
b3783ff 
Pause the timer while on the ending island, reset the timer after exitting a cassette,
and update the timer based on player state and not based on game transition step
@psyGamer
Copy link
Owner

LGTM.

@psyGamer psyGamer merged commit 30e4251 into psyGamer:main Feb 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobofromkirby64 @psyGamer